<html>
<head><meta charset="utf-8"><title>PR 53821: move validation into const_eval query · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html">PR 53821: move validation into const_eval query</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="134922626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134922626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134922626">(Sep 30 2018 at 13:13)</a>:</h4>
<p>I haven't heard back from anyone about <a href="https://github.com/rust-lang/rust/pull/53821" target="_blank" title="https://github.com/rust-lang/rust/pull/53821">https://github.com/rust-lang/rust/pull/53821</a> for more than a week. How do we proceed?</p>



<a name="134933729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134933729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134933729">(Sep 30 2018 at 19:53)</a>:</h4>
<p>the compiler team didn't manage to get through its whole agenda at the last meeting... let me see</p>



<a name="134933774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134933774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134933774">(Sep 30 2018 at 19:54)</a>:</h4>
<p>in terms of the issues you're having not being able to push to <span class="user-mention" data-user-id="124288">@Oli</span> 's branch anymore, my personal appproach would be to close Oli's PR and open your own.</p>



<a name="134933775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134933775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134933775">(Sep 30 2018 at 19:54)</a>:</h4>
<p>(and have the latter PR reference the former)</p>



<a name="134934452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134934452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134934452">(Sep 30 2018 at 20:16)</a>:</h4>
<p>well I was mostly asking for a decision</p>



<a name="134934454"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134934454" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134934454">(Sep 30 2018 at 20:16)</a>:</h4>
<p>'cause reopening will get us at the end of the queue, and IIRC oli's going to be back some time next week</p>



<a name="134935272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134935272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134935272">(Sep 30 2018 at 20:45)</a>:</h4>
<p>Can always slap a p=1 on it</p>



<a name="134983728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134983728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134983728">(Oct 01 2018 at 17:21)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> can you point at a comment that crystallizes the <strong>question</strong> being decided?</p>



<a name="134984185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134984185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134984185">(Oct 01 2018 at 17:28)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I just wrote one: <a href="https://github.com/rust-lang/rust/pull/53821#issuecomment-425993073" target="_blank" title="https://github.com/rust-lang/rust/pull/53821#issuecomment-425993073">https://github.com/rust-lang/rust/pull/53821#issuecomment-425993073</a></p>



<a name="134985476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/PR%2053821%3A%20move%20validation%20into%20const_eval%20query/near/134985476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/PR.2053821.3A.20move.20validation.20into.20const_eval.20query.html#134985476">(Oct 01 2018 at 17:50)</a>:</h4>
<p>ah, right, I remember this now</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>